Hi Nathan, <div>Sorry I didn't find time to work on the grey/black issue. </div><div>This should fix it. I've not tested it extensively. I haven't got my git properly set up on this laptop, so I'm sending the one line fix here:</div>
<div><br></div><div><div>--- a/lib/jpeg_decoder.cpp</div><div>+++ b/lib/jpeg_decoder.cpp</div><div>@@ -309,11 +309,12 @@ int JpegDecoder::DecodeOneBlock(int dht, int comp, int redacting) {</div><div> // Default is the cumulative sum so far.</div>
<div> int value_to_write = dc_values_[comp];</div><div> // If solid, we write out 0.</div><div> if ( redacting != kRedactingEnding) {</div><div> if (redaction_method_ == Redaction::redact_solid)</div><div>
-<span class="Apple-tab-span" style="white-space: pre; "> </span><font class="Apple-style-span" color="#ff0000">value_to_write = 0;</font></div><div>+<span class="Apple-tab-span" style="white-space: pre; "> </span>// Write black.</div>
<div>+<span class="Apple-tab-span" style="white-space: pre; "> </span><font class="Apple-style-span" color="#33ff33">value_to_write = (comp == 0) ? (-127 * (1 << dct_gain_)) : 0;</font></div><div> else if (redaction_method_ == Redaction::redact_copystrip)</div>
<div> <span class="Apple-tab-span" style="white-space: pre; "> </span>value_to_write = redaction_dc_[comp];</div><div> else if (redaction_method_ == Redaction::redact_pixellate ||</div><div> <span class="Apple-tab-span" style="white-space: pre; "> </span> redaction_method_ == Redaction::redact_inverse_pixellate)</div>
<div> <span class="Apple-tab-span" style="white-space: pre; "> </span>value_to_write = LookupPixellationValue(comp);</div></div><div><br></div><div><br></div><div><br></div><div>To do other colours, we would write out non-zero values when comp!=0, and the intensity would need to be some other value. </div>
<div><div>This did bright green:</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>value_to_write = (comp == 0) ? (0 * (1 << dct_gain_)) : ((comp==1) ? -511 : -511);</div></div><div>I'm not sure of the exact scaling that needs to be applied.</div>
<div><a href="http://www.impulseadventure.com/photo/jpeg-color-space.html">http://www.impulseadventure.com/photo/jpeg-color-space.html</a></div><div>Cb= (B-Y)/(2-2*0.114)</div><div>Cr=(R-Y)/(2-2*0.299)</div><div><div><br>
</div><div class="gmail_quote">On Tue, Sep 20, 2011 at 10:26 PM, Nathan of Guardian <span dir="ltr"><<a href="mailto:nathan@guardianproject.info">nathan@guardianproject.info</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Ahem, actually this:<br>
<br>
<a href="https://github.com/guardianproject/SecureSmartCam/ObscuraCam-1.1.1-FINAL.apk/qr_code" target="_blank">https://github.com/guardianproject/SecureSmartCam/ObscuraCam-1.1.1-FINAL.apk/qr_code</a><br>
<br>
/me forgot to refresh his code from the file system when he did the build.<br>
<div><div></div><div class="h5"><br>
On 09/21/2011 12:56 AM, Nathan of Guardian wrote:<br>
> I've built ObscuraCam 1.1-FINAL and update the Android Market and Github.<br>
><br>
> You can download it directly here:<br>
> <a href="https://github.com/guardianproject/SecureSmartCam/ObscuraCam-1.1-FINAL.apk/qr_code" target="_blank">https://github.com/guardianproject/SecureSmartCam/ObscuraCam-1.1-FINAL.apk/qr_code</a><br>
><br>
> I decided to NOT include the native/full res processing in this release,<br>
> because I want to fix the grey/black issue and also solve the thumbnail<br>
> display issue first. I think I know the solution for both, but just need<br>
> a few more days.<br>
><br>
> In the meantime, I think the existing fixes we have were worthy enough<br>
> to push an update. I would like to get more frequent updates out anyhow,<br>
> so doing a 1.2 next week with the native code back in would be fine.<br>
><br>
> Thanks to all for your contributions in both code and testing. Let me<br>
> know if you see anything wrong with this latest update.<br>
><br>
> +n<br>
> _______________________________________________<br>
> Ssc-dev mailing list<br>
><br>
> Post: <a href="mailto:Ssc-dev@lists.mayfirst.org">Ssc-dev@lists.mayfirst.org</a><br>
> List info: <a href="https://lists.mayfirst.org/mailman/listinfo/ssc-dev" target="_blank">https://lists.mayfirst.org/mailman/listinfo/ssc-dev</a><br>
><br>
> To Unsubscribe<br>
> Send email to: <a href="mailto:Ssc-dev-unsubscribe@lists.mayfirst.org">Ssc-dev-unsubscribe@lists.mayfirst.org</a><br>
</div></div>> Or visit: <a href="https://lists.mayfirst.org/mailman/options/ssc-dev/nathan%40guardianproject.info" target="_blank">https://lists.mayfirst.org/mailman/options/ssc-dev/nathan%40guardianproject.info</a><br>
><br>
> You are subscribed as: <a href="mailto:nathan@guardianproject.info">nathan@guardianproject.info</a><br>
<div><div></div><div class="h5"><br>
_______________________________________________<br>
Ssc-dev mailing list<br>
<br>
Post: <a href="mailto:Ssc-dev@lists.mayfirst.org">Ssc-dev@lists.mayfirst.org</a><br>
List info: <a href="https://lists.mayfirst.org/mailman/listinfo/ssc-dev" target="_blank">https://lists.mayfirst.org/mailman/listinfo/ssc-dev</a><br>
<br>
To Unsubscribe<br>
Send email to: <a href="mailto:Ssc-dev-unsubscribe@lists.mayfirst.org">Ssc-dev-unsubscribe@lists.mayfirst.org</a><br>
Or visit: <a href="https://lists.mayfirst.org/mailman/options/ssc-dev/andrew.senior%40gmail.com" target="_blank">https://lists.mayfirst.org/mailman/options/ssc-dev/andrew.senior%40gmail.com</a><br>
<br>
You are subscribed as: <a href="mailto:andrew.senior@gmail.com">andrew.senior@gmail.com</a><br>
</div></div></blockquote></div><br></div>