[Assword] maybe use -compress-algo NULL by default?

[Jameson Graef Rollins]

On Thu, May 08 2014, Daniel Kahn Gillmor <dkg at fifthhorseman.net> wrote:
> On 05/08/2014 05:14 PM, Jameson Graef Rollins wrote:
>
>> Hi, Daniel.  This seems like a reasonable way forward once upstream adds
>> the option.  But let's wait until we know what the option will be, then
>> we can make this change appropriately.
>
> Upstream gpgme has already added the option as
> GPGME_ENCRYPT_NO_COMPRESS.  you can see it in commit ID 991cde9e79fec of
> git://git.gnupg.org/gpgme.git.
>
> python-gpgme deals with constants in src/pygpgme-constants.c with the
> following sort of structures:
>
> #define CONST(name) { #name, GPGME_##name }
>
> static const struct pygpgme_constant constants[] = {
>   /* gpgme_data_encoding_t */
>   CONST(DATA_ENCODING_NONE),
>   CONST(DATA_ENCODING_BINARY),
>   CONST(DATA_ENCODING_BASE64),
>   CONST(DATA_ENCODING_ARMOR),
>
>   [...]
>
>   /* gpgme_encrypt_flags_t */
>   CONST(ENCRYPT_ALWAYS_TRUST),
>
>   [...]
> };
>
> It seems clear to me that if python-gpgme ever adds the constant, it
> will be using the same label described in the patch.
>
> We could wait before applying, but remembering seems like more trouble
> than just fixing it in asswor now and waiting for it to be fixed
> automatically when the dependencies eventually catch up.

Ok.  If you think it's a good idea to add this now that's ok with me.

If you could send a full patch (with good log message) to the list, or
push one to your repo, I'll pull and include in the upcoming release.

Thanks.

jamie.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <https://lists.mayfirst.org/mailman/private/assword/attachments/20140508/e9569999/attachment.pgp>