[guardian-dev] [PATCH 0/3] Some fixes for XMPP contact list creation
Nathan of Guardian
nathan at guardianproject.info
Sun Nov 21 14:51:18 EST 2010
Thanks for tracking that annoying issue down and providing the patches.
I will review this evening and provide feedback.
We haven't been sending patches to the -dev list, but since we are
trying to expand the circle a bit to a larger community now, especially
on the OTRChat project, it seems like a beneficial idea.
On 11/20/2010 05:23 PM, Adrian-Ken Rueegsegger wrote:
> The bug was that only contacts which belong to a group were processed so all
> others simply did not show up. The first patch fixes this by adding all unfiled
> entries in the user's roster to the default list.
> The other two patches are some minor cleanup/refactor patches. My Java is
> rather rusty since I have not used it in years so I would be glad if you could
> comment on the patches and also on the style and provide some information on how
> to things should be done properly. Also since this is my first submission of
> patches to this project I was not sure what the prefered workflow is. Please
> tell me if sending patches to the dev mailing list is not the proper way and how
> it should be done properly. Thanks!
More information about the Guardian-dev