[guardian-dev] [PATCH] Update GibberBot info in the Orbot help wizard

[Hans-Christoph Steiner]

On Mar 22, 2011, at 10:19 PM, Sathyanarayanan Gunasekaran wrote:

>
> Hello,
>
>
> Thanks for the patch!  It seems to be generated from SVN and based  
> on an
> older version of the source, so I couldn't apply it.
>
> Oh, I checked out the source from https://svn.torproject.org/svn/projects/android/trunk/Orbot/
> I'm not sure if that's been updated to 1.0.4.1 (or if that's the  
> problem)
>
> Though git is hard
> to learn, it is worth the effort, especially if you want to work on a
> project that uses git.
>
>
> Oh, is Orbot source on git?


Doh, sorry, I just realized now, this is meant to be a patch to Orbot,  
I thought it was for Gibberbot.  So ignore my comments about SVN and  
not applying.

.hc



>
> The
> patch you sent does include one non-relevant change: the edits
> to .classpath.  While this particular change may seem harmless, it  
> might
> make it harder to apply.
>
> Oh sorry about that, I wasn't sure whether to edit it out or not !
>
> Also, including more changes in a patch means
> more code to review.  One commit/patch is not a big deal, but it  
> adds up
> when there are many commits.
>
> Thanks I'll keep that in mind !
>
> Thanks a lot for your feedback ! If you could point me to the latest  
> source, I'd be happy to
> make the changes again and send a fresh patch.
>
> Thanks,
> Sathya
>





----------------------------------------------------------------------------

"Free software means you control what your computer does. Non-free  
software means someone else controls that, and to some extent controls  
you." - Richard M. Stallman


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mayfirst.org/pipermail/guardian-dev/attachments/20110323/1dcce6c5/attachment.htm>